Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise ConfigEntryNotReady when unable to connect during setup of AVM Fritz!Smarthome #97985

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Aug 7, 2023

Proposed change

This is the last missing part to accomplish #97086 and needs a bump of pyfritzhome to 0.6.9

DRAFT: wait for the pyfritzhome release

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 7, 2023

Hey there @flabbamann, mind taking a look at this pull request as it has been labeled with an integration (fritzbox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritzbox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritzbox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@mib1185 mib1185 marked this pull request as ready for review August 7, 2023 18:44
@gjohansson-ST
Copy link
Member

@mib1185 please resolve conflicts and undraft once ready.
Also it needs additional tests to get coverage

@gjohansson-ST gjohansson-ST marked this pull request as draft August 13, 2023 13:55
@mib1185 mib1185 force-pushed the fritz/raise-not-ready-during-setup-if-unable-to-connection branch from 8d5468f to 6769d20 Compare August 13, 2023 20:04
@mib1185 mib1185 marked this pull request as ready for review August 13, 2023 20:05
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

../Frenck

@frenck frenck merged commit 533a8be into home-assistant:dev Aug 14, 2023
34 checks passed
@mib1185 mib1185 deleted the fritz/raise-not-ready-during-setup-if-unable-to-connection branch August 14, 2023 09:34
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVM FRITZ!SmartHome must reconfigured every day
3 participants