Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switch platform to Schlage #98004

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Conversation

dknowles2
Copy link
Contributor

@dknowles2 dknowles2 commented Aug 7, 2023

Proposed change

Introduce a switch platform to Schlage with the following entities:

  • Beeper (Keypress beep)
  • Lock and Leave (1-touch locking)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Aug 8, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 8, 2023 14:58
@dknowles2 dknowles2 marked this pull request as ready for review August 9, 2023 12:23
@home-assistant home-assistant bot requested a review from joostlek August 9, 2023 12:23
@dknowles2 dknowles2 requested a review from joostlek August 9, 2023 13:17
@joostlek joostlek changed the title Schlage: Add switch platform with two entities Add switch platform to Schlage Aug 9, 2023
@joostlek joostlek merged commit 023f2f8 into home-assistant:dev Aug 9, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
@dknowles2 dknowles2 deleted the schlage-beep branch September 4, 2023 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants