Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.8.2 #98255

Merged
merged 44 commits into from
Aug 11, 2023
Merged

2023.8.2 #98255

merged 44 commits into from
Aug 11, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 11, 2023

Docs PR: home-assistant/home-assistant.io#28540

karwosts and others added 30 commits August 11, 2023 14:17
* Add device naming to Yeelight

* Add extra light entity to fix superclass

* Add extra light entity to fix superclass
* Fix for issue #97694

Issue #97694 points out that the visibility range is a string with a band of distances, not a single value, which is causing issues for front end components. Removed the device class to leave as an informational string value.

* Removed *all* empty device_class statements

* Missed an empty device_class :(
… `hw_info` (#97766)

Don't assume that battery_level value is always present in hw_info
* Bumping to PyTado 0.16 and adding test coverage

* Removing comment

* Upgrading the deprecated functions

* Updating tests to support paramterization

* Delete test_config_flow.py

Reverting the tests, which will be placed in a different PR.

* Revert "Delete test_config_flow.py"

This reverts commit 1719ebc.

* Reverting back changes
* Ensure webhooks take HA cloud into account

* Avoid circular import
* Bump pysensibo to 1.0.33

* for loop
Bump bimmer_connected to 0.13.9

Co-authored-by: rikroe <rikroe@users.noreply.github.com>
* Fix homekit_controller triggers when value is None

* fixes

* cover
* bump to 0.32.2

* fix test
Co-authored-by: alexyao2015 <alexyao2015@users.noreply.github.com>
The tomorrow.io integration isn't working for new users due to changes made by tomorrow.io. This fixes that with the following changes:
* Add 60 minute timestep option
* Change default timestep to 60 minutes
@home-assistant home-assistant bot added cla-signed merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`. labels Aug 11, 2023
@bdr99
Copy link
Contributor

bdr99 commented Aug 11, 2023

Can this be added to the patch release please?

#98084

@frenck
Copy link
Member Author

frenck commented Aug 11, 2023

Can this be added to the patch release please?

CleanShot 2023-08-11 at 16 02 39

@bdr99 That PR was merged two days ago? How is this comment made only now and here? 🤷

@bdr99
Copy link
Contributor

bdr99 commented Aug 11, 2023

@frenck I had asked in the PR description if it could be added to the next patch release. I noticed that it wasn't added, so that's why I commented here. Is there some other place I should be asking instead?

@frenck
Copy link
Member Author

frenck commented Aug 11, 2023

@frenck I had asked in the PR description if it could be added to the next patch release. I noticed that it wasn't added

Well, the PR should have been the place to handle this, before this all happens.

I will add it, but it sets me back about an hour in the release process. Just to give a small idea:

  • Re-open the milestone
  • Tag the PR on it
  • Cherry-pick the PR to the RC & push it out
  • Close the milestone and make sure nothing came back on it again in the mean time.
  • Generate new patch release notes
  • Open the documentation PR locally, update the release notes, push that out.
  • Wait for all CI to finish in the next hour
  • Get re-approvals

Like, I'm happy to do that. But it is better to avoid :)

../Frenck

@bdr99
Copy link
Contributor

bdr99 commented Aug 11, 2023

@frenck Thank you, and sorry to cause you all of that extra work. If there is anything I should have done differently to prevent this from happening, please let me know. I'm not sure what I could have done beyond asking in the PR description.

@frenck
Copy link
Member Author

frenck commented Aug 11, 2023

Thank you, and sorry to cause you all of that extra work. If there is anything I should have done differently to prevent this from happening, please let me know. I'm not sure what I could have done beyond asking in the PR description.

No problem, as I said happy to do that. It was missed in the PR review, which is a bummer. But something you could have checked for after the merge maybe.

It is interesting though, as this happens at times. But it also just now made me realize how often we ask if something should or should not go into a patch release in reviews. Maybe something the bot / PR template could help us with 🤔

../Frenck

@gjohansson-ST
Copy link
Member

It is interesting though, as this happens at times. But it also just now made me realize how often we ask if something should or should not go into a patch release in reviews. Maybe something the bot / PR template could help us with 🤔

Maybe for a discussion elsewhere but clicking the bugfix in the PR description and/or write as such in the PR title would have helped (and could be picked up by the bot)

@gjohansson-ST
Copy link
Member

In PR description link to docs PR is wrong and is home-assistant/home-assistant.io#28540

@frenck frenck merged commit 73898da into master Aug 11, 2023
71 of 72 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed merging-to-master This PR is merging into the RC branch and should probably change the branch to `dev`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet