Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifi add port forward control to switch platform #98309

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Aug 12, 2023

Breaking change

Proposed change

Allow controlling port forwarding in UniFi

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kane610 you probably know better than me, but shouldn't aiounifi be upgraded first and after that add the port forward control functionality in a different PR?

@Kane610
Copy link
Member Author

Kane610 commented Aug 16, 2023

@Kane610 you probably know better than me, but shouldn't aiounifi be upgraded first and after that add the port forward control functionality in a different PR?

This is typically how at least I've done it since forever. The only changes for the library is for port forward control :)

@Noltari
Copy link
Contributor

Noltari commented Aug 16, 2023

@Kane610 you probably know better than me, but shouldn't aiounifi be upgraded first and after that add the port forward control functionality in a different PR?

This is typically how at least I've done it since forever. The only changes for the library is for port forward control :)

Ok, no problem then :)

@gjohansson-ST
Copy link
Member

@Kane610
Copy link
Member Author

Kane610 commented Aug 18, 2023

Kane610/aiounifi@v53...v54#diff-337a9fb8934de299dd2b73f984e86594251476b3de9893e4b777d9e1a772e8e2R245
Should that print really be there?

No it shouldn't... I've removed it in the following library release Kane610/aiounifi@v54...v55 which will be brought in by #98549

@Kane610 Kane610 force-pushed the unifi-add_port_forward_control_to_switch_platform branch from 388b2ea to fd8afab Compare August 18, 2023 20:51
@Kane610
Copy link
Member Author

Kane610 commented Aug 18, 2023

#98549 has been merged so no issue with the stale print in the library anymore.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit d0d160f into home-assistant:dev Aug 21, 2023
21 checks passed
@Kane610 Kane610 deleted the unifi-add_port_forward_control_to_switch_platform branch August 21, 2023 20:55
@Kane610
Copy link
Member Author

Kane610 commented Aug 21, 2023

Awesome! Thank you @frenck 🎉

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants