Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi refactor using site data #98549

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Aug 16, 2023

Breaking change

Proposed change

Improve how sites are being used and remove the use of site description API as the relevant information is available in site.
Kane610/aiounifi@v54...v55
New APIs in aiounifi are affecting some tests counting amount of http requests made (reflected in last commit).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 force-pushed the unifi-improve_reading_site_data branch from fbc5061 to 01217f1 Compare August 16, 2023 20:05
Copy link
Contributor

@Noltari Noltari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Kane610
Copy link
Member Author

Kane610 commented Aug 18, 2023

Thank you very much @elupus 🎉

@Kane610 Kane610 merged commit 9e42451 into home-assistant:dev Aug 18, 2023
34 checks passed
@Kane610 Kane610 deleted the unifi-improve_reading_site_data branch August 18, 2023 20:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants