New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin info support for MQTT discovered items #98782
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, some comments though
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but we should adapt names in the code
d78ab4d
to
2b396c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @jbouwh 👍
Proposed change
Make it possible to define the source of MQTT discovery messages via a new optional dict
origin
. This will be logged when an MQTT entity or other component is first added and when the configuration is changed.Examples
Assuming we want to discover a
sensor
entity and we publish a config payload tohomeassistant/sensor/bla/config
.Example of a configuration payload without integration info:
... would log:
Found new component: sensor bla
With minimal integration info:
... would log:
Found new component: sensor bla from from external application bla2mqtt
Additional software version and a support URL can be supplied:
... would log:
Found new component: sensor bla from external application bla2mqtt, version: 1.1, support URL: https://bla2mqtt.example.com/support
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: