Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UniFi device uptime and temperature sensors #99307

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Aug 29, 2023

Breaking change

Proposed change

Kane610/aiounifi@v58...v59
Add new device sensors from new properties added in v59.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kane610 👍

@edenhaus
Copy link
Contributor

edenhaus commented Sep 3, 2023

@Kane610 Can you please create a PR for the documentation?

@Kane610
Copy link
Member Author

Kane610 commented Sep 3, 2023

@Kane610 Can you please create a PR for the documentation?

Absolutely, I will do it after Wednesday release of HA.

@jcallaghan
Copy link
Contributor

@Kane610 not sure where is best to initiate this question from so please forgive me and please feel free to direct me elsewhere!

Could I ask if the IP attribute of my UDM device_tracker entity (the WAN address) is obtained via the same way you're getting the temperature of the device?

The reason I ask is that I recently added an LTE-PRO to my setup. If I force a failover to the LTE, the IP attribute doesn't seem to update. I'm having to use DNS IP integration which is cloud dependant and adds latency as it requires my UDM to update DDNS and then the integration to detect the change in 2 minutes intervals. While I'm notified of the failover event within ~5 minutes I was curious if the WAN IP was available locally in a similar way to this PR?

@Kane610
Copy link
Member Author

Kane610 commented Sep 9, 2023

@Kane610 not sure where is best to initiate this question from so please forgive me and please feel free to direct me elsewhere!

Could I ask if the IP attribute of my UDM device_tracker entity (the WAN address) is obtained via the same way you're getting the temperature of the device?

The reason I ask is that I recently added an LTE-PRO to my setup. If I force a failover to the LTE, the IP attribute doesn't seem to update. I'm having to use DNS IP integration which is cloud dependant and adds latency as it requires my UDM to update DDNS and then the integration to detect the change in 2 minutes intervals. While I'm notified of the failover event within ~5 minutes I was curious if the WAN IP was available locally in a similar way to this PR?

Better you create an issue here https://github.com/Kane610/aiounifi and we'll talk there

@Kane610 Kane610 enabled auto-merge (squash) September 9, 2023 09:03
@Kane610 Kane610 closed this Sep 9, 2023
auto-merge was automatically disabled September 9, 2023 09:03

Pull request was closed

@Kane610 Kane610 reopened this Sep 9, 2023
@Kane610 Kane610 merged commit cf47a6c into home-assistant:dev Sep 9, 2023
35 checks passed
@Kane610 Kane610 deleted the unifi-device_uptime_sensor branch September 9, 2023 09:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants