Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Renson button entity #99494

Merged
merged 16 commits into from
Sep 21, 2023
Merged

Conversation

jimmyd-be
Copy link
Contributor

@jimmyd-be jimmyd-be commented Sep 2, 2023

Breaking change

Proposed change

Creation of button sensor for syncing the time to the device and restarting device.

Dependecy has been updated because of a bug in it for syncing time incorrectly to the device.
Previously when syncing the time it throws an python error that datetime cannot be found in datetime. The update fixes this. jimmyd-be/Renson-endura-delta-library@1.5.0...1.6.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@gjohansson-ST
Copy link
Member

Please add a link to the changelog, or at minimum a diff between library versions to the PR description when bumping library

@jimmyd-be
Copy link
Contributor Author

jimmyd-be commented Sep 2, 2023

Dependecy has been updated because of a bug in it for syncing time incorrectly to the device.
Previously when syncing the time it throws an python error that datetime cannot be found in datetime. The update fixes this.

I added more details to the PR:
Dependecy has been updated because of a bug in it for syncing time incorrectly to the device.
Previously when syncing the time it throws an python error that datetime cannot be found in datetime. The update fixes this. jimmyd-be/Renson-endura-delta-library@c0d293a

@jimmyd-be jimmyd-be mentioned this pull request Sep 2, 2023
20 tasks
@jimmyd-be jimmyd-be changed the title Renson sync time button Renson button entity Sep 2, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use tags in the third-party library and add a link to the description with the diff between the currently used tag and the new one. This diff is required as the reviewer also are doing some sanity checks.

We only allow multiple "Type of change" in one PR, if it is impossible to separate things. In your case, I think we can split the dependency dump into a new PR. If this PR requires the dependency dump, please leave it in draft until the other one is merged.

@home-assistant
Copy link

home-assistant bot commented Sep 3, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 3, 2023 16:21
@jimmyd-be jimmyd-be marked this pull request as ready for review September 7, 2023 16:40
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/strings.json Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 7, 2023 17:45
@edenhaus
Copy link
Contributor

edenhaus commented Sep 7, 2023

Sanity check for 1.6.0 ✔️

@jimmyd-be jimmyd-be marked this pull request as ready for review September 7, 2023 18:00
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase to resolve conflicts

@home-assistant home-assistant bot marked this pull request as draft September 7, 2023 19:29
@jimmyd-be jimmyd-be marked this pull request as ready for review September 9, 2023 06:16
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase.
Please click "Ready for review" when done, Thanks 👍

@jimmyd-be jimmyd-be marked this pull request as ready for review September 11, 2023 16:41
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 12, 2023 19:15
@jimmyd-be jimmyd-be marked this pull request as ready for review September 16, 2023 12:48
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
homeassistant/components/renson/button.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 21, 2023 10:24
jimmyd-be and others added 8 commits September 21, 2023 14:21
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
@jimmyd-be jimmyd-be marked this pull request as ready for review September 21, 2023 13:04
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmyd-be 👍

@edenhaus edenhaus changed the title Renson button entity Add Renson button entity Sep 21, 2023
@edenhaus edenhaus merged commit e57156d into home-assistant:dev Sep 21, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants