-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Renson button entity #99494
Add Renson button entity #99494
Conversation
Please add a link to the changelog, or at minimum a diff between library versions to the PR description when bumping library |
I added more details to the PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use tags in the third-party library and add a link to the description with the diff between the currently used tag and the new one. This diff is required as the reviewer also are doing some sanity checks.
We only allow multiple "Type of change" in one PR, if it is impossible to separate things. In your case, I think we can split the dependency dump into a new PR. If this PR requires the dependency dump, please leave it in draft until the other one is merged.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sanity check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase to resolve conflicts
d1a6c15
to
8af1732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase.
Please click "Ready for review" when done, Thanks 👍
8af1732
to
d14a7e2
Compare
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimmyd-be 👍
Breaking change
Proposed change
Creation of button sensor for syncing the time to the device and restarting device.
Dependecy has been updated because of a bug in it for syncing time incorrectly to the device.
Previously when syncing the time it throws an python error that datetime cannot be found in datetime. The update fixes this. jimmyd-be/Renson-endura-delta-library@1.5.0...1.6.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: