feature enhancement: add native picotts library to docker image so offline TTS (text-to-speech) option is available by default

[kngharv]

add one single line to Dockerfile to include picotts library

https://community.home-assistant.io/t/integrate-native-picotts-library-into-hass-io-home-assistant-docker-image/186309/4

https://github.com/home-assistant/docker/issues/114

[homeassistant]

Hello @kngharv,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

• bd9fc6f45e58ecd963e2d78f2a410deebcb44e20 - This commit has something that looks like an email address (kngharv@gmail.com). Maybe try linking that to GitHub?.

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

   • If you only made a single commit you should be able to run

     git commit --amend --author="Author Name <email@address.com>"
     

     (substituting Author Name and email@address.com for your actual information) to set the authorship information.
   • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
     1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
     2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
   • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

[kngharv]

re-submit with email link to github

[frenck]

We should not use edge. As pico depends on musl, and the musl lib currently on edge isn't compatible with the stable version; this will break.

Instead, if we want to include this, we need to build it from source.

[kngharv]

Normally, I wouldn't even bother you guys to include something from "edge."

But from layman's eye, it seems that the picotts code is relatively stable and hasn't been modified for ages.

I did a basic sanity test on my own and made sure the picotts actually worked before I did the pull request. Nothing broke based upon my very limited test (docker on x86_64 linux host).

On the other hand, since I am absolutely clueless about intricacies of various libc libraries, I am going to assume your concern is real.

My question to you is, what is the best way to moving this forward? compile picotts against a stable musl? switch to glibc altogether?

[frenck]

There is no glibc here, as this is all Alpine Linux and thus musl.

The concern is real and actually a current issue. It is not a concern about Pico itself, it is a concern with the binary that is on the edge repo, which is compiled against a newer libmusl. If Pico is added to this base image, it needs to be compiled from the source in-place, right here in this Dockerfile.

[carstencodes]

So, if I see it correctly, this would result into a multi-image build: The first image is to create picotts from source using regulare build utilities. (automake, make, gcc). Since these tools are not required in production, the line would result into a COPY --from ... expression, if I am right. This would definitely be a harder worker to do.

@frenck Do you have experiences with that or should I try to get a working copy for it next week during my vacation?

[pvizeli]

not realy, just a build like we do for other software... Keep it simple make it smart.

[carstencodes]

Yeah, I just saw that build-utils are installed in the base image. I usually skip this package, if it is not required at runtime.

[carstencodes]

Ok, I found it:

docker run -it alpine:3.12

$ apk update && apk add automake autoconf git libtool popt-dev git build-base && mkdir -p /tmp/pico && https://github.com/naggety/picotts.git /tmp/pico && cd /tmp/pico/pico && ./autogen.sh && ./configure && make && make install && cd - && rm -rfv /tmp/pico

This should build pico-tts

cc @kngharv