Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature enhancement: add native picotts library to docker image so offline TTS (text-to-speech) option is available by default #135

Closed
wants to merge 1 commit into from
Closed

feature enhancement: add native picotts library to docker image so offline TTS (text-to-speech) option is available by default #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ RUN apk add --no-cache \
&& apk del .build-dependencies \
&& rm -rf /usr/src/arp-scan

# PicoTTS
RUN apk add --no-cache \
picotts --repository=http://dl-cdn.alpinelinux.org/alpine/edge/testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not use edge. As pico depends on musl, and the musl lib currently on edge isn't compatible with the stable version; this will break.

Instead, if we want to include this, we need to build it from source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, I wouldn't even bother you guys to include something from "edge."

But from layman's eye, it seems that the picotts code is relatively stable and hasn't been modified for ages.

I did a basic sanity test on my own and made sure the picotts actually worked before I did the pull request. Nothing broke based upon my very limited test (docker on x86_64 linux host).

On the other hand, since I am absolutely clueless about intricacies of various libc libraries, I am going to assume your concern is real.

My question to you is, what is the best way to moving this forward? compile picotts against a stable musl? switch to glibc altogether?

Copy link
Member

@frenck frenck Sep 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no glibc here, as this is all Alpine Linux and thus musl.

The concern is real and actually a current issue. It is not a concern about Pico itself, it is a concern with the binary that is on the edge repo, which is compiled against a newer libmusl. If Pico is added to this base image, it needs to be compiled from the source in-place, right here in this Dockerfile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I see it correctly, this would result into a multi-image build: The first image is to create picotts from source using regulare build utilities. (automake, make, gcc). Since these tools are not required in production, the line would result into a COPY --from ... expression, if I am right. This would definitely be a harder worker to do.

@frenck Do you have experiences with that or should I try to get a working copy for it next week during my vacation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not realy, just a build like we do for other software... Keep it simple make it smart.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just saw that build-utils are installed in the base image. I usually skip this package, if it is not required at runtime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I found it:

docker run -it alpine:3.12

$ apk update && apk add automake autoconf git libtool popt-dev git build-base && mkdir -p /tmp/pico && https://github.com/naggety/picotts.git /tmp/pico && cd /tmp/pico/pico && ./autogen.sh && ./configure && make && make install && cd - && rm -rfv /tmp/pico

This should build pico-tts

cc @kngharv


# Telldus
RUN apk add --no-cache \
confuse \
Expand Down