-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stop Effect to Lights more-info dialog #3619
Comments
If we would go for a button, only show it if we know an effect is active. I think I prefer making it part of the dropdown. |
There is one minor discoverability issue with the dropdown idea however. If the "stop effect" choice is hidden until an effect is active, the user doesn't see it when opening the dropdown menu and they wouldn't necessarily know it was added either because the dropdown closes immediately after they make their selection. So if this is possible, maybe have the "show effect" option be visible in the dropdown at all times but just in an unselectable/disabled until there is an active effect? And it probably should be at the very bottom of the effect list too. |
Maybe instead of "Stop Effect" we change it to "No Effect" and make that the default option? |
I like "No Effect". Going to add that. |
Looked at the code and it is just a list of effects, so for now just going to have "stop" for now. It will not be hidden. Edit: Changing my mind. Going to go with a button. That will be cleaner |
Can you check if there is an effect attribute after calling the turn_on with an effect of "stop"? |
* Convert weather-forecast to LitElement Part of #2095 Not sure how RTL works and how to apply it. Also, thinking I should update if the forecast changes and not just the state. Input? * Revert "Convert weather-forecast to LitElement" This reverts commit e1893b0. * Add stop effect button Closes #3619 * address review comments * cleanup
As I understand the (partial) fix has been reverted in #3672, right? Could this issue be reopened then? I understand that there's no perfect solution for all devices right now, but having to power-cycle the light to turn off an effect is still annoying. |
I don't believe this is a frontend issue. The backend would have to change to have all integrations follow a similar method of stopping effects, if even possible before the frontend could support it. |
This issue was moved by iantrich to home-assistant/core#32446. |
Description of problem:
You can turn on light effects from the more-info dialog for Lights, but there is no apparent way to turn these effects off. Seems that you have to turn the light off and then back on again, which is not obvious and can be a little confusing. Some examples of community posts referencing this: here, here, here.
It seems that sending
effect: stop
will stop the effect and restore your lights. I've tested this with Hue and it seems to work, but I am not 100% positive if this is a standard Home Assistant thing that all light platforms support?I think that there should either be a "stop" option added inside of the dropdown when an effect is currently active like this (mockup 1):
Or a stop button to the right of the "Effect" dropdown as pictured here (mockup 2):
The text was updated successfully, but these errors were encountered: