Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python to js timestamp conversions in logbook traces #12677

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 13, 2022

Proposed change

  • The websocket version needs the time converted from
    where python stores the decimal

I didn't realize these were accessed outside the logbook model

Is there a better way to fix this? Ideally it would get converted at a sooner place but I'm not sure where that would be best to do that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

- The websocket version needs the time converted from
  where python stores the decimal
@bdraco bdraco marked this pull request as ready for review May 13, 2022 01:46
@bdraco bdraco added the Bug Fix label May 13, 2022
@balloob
Copy link
Member

balloob commented May 16, 2022

I don't think that we can do it earlier. On access is the best approach so we don't compute data that won't end up being used.

@balloob balloob merged commit 6c48ace into home-assistant:dev May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants