Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify OAuth2 authorize callback URL #12765

Merged
merged 2 commits into from
May 24, 2022
Merged

Simplify OAuth2 authorize callback URL #12765

merged 2 commits into from
May 24, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented May 24, 2022

Proposed change

Simplify:

https://my.home-assistant.io/redirect/oauth2_authorize_callback

->

https://my.home-assistant.io/redirect/oauth

Mainly because we have to document this URL and expect our users to enter it in their application configuration.

home-assistant/my.home-assistant.io#240

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit e7517a8 into dev May 24, 2022
@balloob balloob deleted the frenck-2022-1089 branch May 24, 2022 20:32
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants