-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ha-fab (Material 3) #16035
Update ha-fab (Material 3) #16035
Conversation
M3 fab is in alpha for now. It should we should wait some updates and stabilisation before updating it do avoid breaking changes. At least beta step should be fine ?
Also, we need to define a global theme to have a consistent look at feeling across all m3 UI components. |
I definitely agree that we should make a global theme. I don't think the FAB will have breaking changes, but if you think this shouldn't be merged yet then that's understandable. |
here's my first bit of work at a global theme --md-sys-color-primary: var(--primary-color);
--md-sys-color-on-primary: var(--text-primary-color);
/* TODO secondary + container */
/* TODO tertiary + container */
--md-sys-color-background: var(--primary-background-color);
--md-sys-color-on-background: var(--primary-text-color);
--md-sys-color-surface: var(--primary-background-color);
--md-sys-color-on-surface: var(--primary-text-color);
/* TODO inverse-surface (should we just switch them?) also inverse-primary (should we just use primary?) */
--md-sys-color-surface-variant: var(--card-background-color);
--md-sys-color-on-surface-variant: var(--secondary-text-color);
--md-sys-color-outline: var(--secondary-text-color);
--md-sys-color-outline-variant: var(--divider-color);
--md-sys-color-error: var(--error-color);
--md-sys-color-on-error: white;
/* TODO error container */
/* TODO shadow, scrim (should we just use black always?) */ |
Over in the Discord I asked about a problem I'm having:
Nobody responded (besides Bram who seemed to not get what I meant, then ghosted me). Any ideas here on how to resolve this issue? |
Great, we still need to wait for |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Stale. |
Proposed change
Updates ha-fab to use
![image](https://user-images.githubusercontent.com/10727862/229523447-735aeed1-db3e-4cb5-a48b-ec446ab4c4de.png)
@material/web
(Material 3) for the FAB instead of@material/mwc-fab
.With the new FAB component, the styling, capitalization, and attributes available have changed.
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: