Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Material Design 3 tokens based on HA design kit #20108

Closed
wants to merge 1 commit into from

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Mar 17, 2024

Proposed change

Introduce Material Design 3 tokens based on HA design kit.
See the discussion in #18661.
Unblocks #16035 and #16023 and allows to adopt Material Design 3 faster.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon changed the title Introduce a Material Design 3 theme based on HA design kit Introduce Material Design 3 tokens based on HA design kit Mar 17, 2024
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change as --md-sys-color-primary will not be set using --primary-color for example.
I will discuss with the design team to see how we want to manage the migration to material 3 in a global way. That's why we scoped the variable to components for now.

@silamon
Copy link
Contributor Author

silamon commented Mar 19, 2024

I see what you mean. I think I will need to bring the current tokens into the m3 tokens earlier than I thought. Looking forward to the feedback. Perhaps we may have to do the components first.

@silamon silamon marked this pull request as draft March 20, 2024 17:57
@piitaya
Copy link
Member

piitaya commented Apr 2, 2024

I discussed with the design team. The global material theme is not ready yet and we want to wait for a design decision before implementing global theme variables.

For now we only have primary and secondary color as theme variable (see screenshot below).

Material design 3 provides algorithm to generate key colors and tonal palettes (source: https://m3.material.io/styles/color/system/how-the-system-works). We want to look at the design level how we want to implement this to Home Assistant before implementing it in code.

Thanks for the contributions but for now we are closing this PR while waiting for the design. M3 variables should be set per component for now.

Primary and secondary color in HA
CleanShot 2024-04-02 at 11 34 16

@piitaya piitaya closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sliders (and maybe more) are missing on-primary styling
2 participants