Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overflow menu being above dialogs #16558

Merged
merged 1 commit into from May 17, 2023
Merged

Conversation

bramkragten
Copy link
Member

Proposed change

The overflow menu would not close, and be above the dialog, this fixes it in 2 ways, the overflow menu now closes, and the dialog will be above the overflow if it(somewhere else?) doesn't close.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@steverep steverep merged commit eb220fa into dev May 17, 2023
7 checks passed
@steverep steverep deleted the fix-device-actions-overflow branch May 17, 2023 14:23
piitaya pushed a commit that referenced this pull request May 23, 2023
Fix device actions being above dialogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants