Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow menu being above dialogs #16558

Merged
merged 1 commit into from May 17, 2023
Merged

Fix overflow menu being above dialogs #16558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ha-dialog.ts
View file
Open in desktop
Expand Up @@ -72,7 +72,7 @@ export class HaDialog extends DialogBase {
--dialog-scroll-divider-color,
var(--divider-color)
);
z-index: var(--dialog-z-index, 7);
z-index: var(--dialog-z-index, 8);
-webkit-backdrop-filter: var(--dialog-backdrop-filter, none);
backdrop-filter: var(--dialog-backdrop-filter, none);
--mdc-dialog-box-shadow: var(--dialog-box-shadow, none);
Expand Down
2 changes: 1 addition & 1 deletion src/components/media-player/dialog-media-manage.ts
View file
Open in desktop
Expand Up @@ -277,7 +277,7 @@ class DialogMediaManage extends LitElement {
haStyleDialog,
css`
ha-dialog {
--dialog-z-index: 8;
--dialog-z-index: 9;
--dialog-content-padding: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/media-player/dialog-media-player-browse.ts
View file
Open in desktop
Expand Up @@ -142,7 +142,7 @@ class DialogMediaPlayerBrowse extends LitElement {
haStyleDialog,
css`
ha-dialog {
--dialog-z-index: 8;
--dialog-z-index: 9;
--dialog-content-padding: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/dialogs/quick-bar/ha-quick-bar.ts
View file
Open in desktop
Expand Up @@ -775,7 +775,7 @@ export class QuickBar extends LitElement {
}

ha-dialog {
--dialog-z-index: 8;
--dialog-z-index: 9;
--dialog-content-padding: 0;
}

Expand Down
88 changes: 44 additions & 44 deletions src/panels/config/devices/ha-config-device-page.ts
View file
Open in desktop
Expand Up @@ -755,52 +755,52 @@ export class HaConfigDevicePage extends LitElement {
)}
.path=${mdiDotsVertical}
></ha-icon-button>
${actions.map(
(deviceAction) => html`
<a
href=${ifDefined(deviceAction.href)}
target=${ifDefined(deviceAction.target)}
rel=${ifDefined(
deviceAction.target
? "noreferrer"
: undefined
)}
>
<mwc-list-item
class=${ifDefined(
deviceAction.classes
${actions.map((deviceAction) => {
const listItem = html`<mwc-list-item
class=${ifDefined(deviceAction.classes)}
.action=${deviceAction.action}
@click=${this._deviceActionClicked}
graphic="icon"
.hasMeta=${Boolean(
deviceAction.trailingIcon
)}
>
${deviceAction.label}
${deviceAction.icon
? html`
<ha-svg-icon
class=${ifDefined(
deviceAction.classes
)}
.path=${deviceAction.icon}
slot="graphic"
></ha-svg-icon>
`
: ""}
${deviceAction.trailingIcon
? html`
<ha-svg-icon
slot="meta"
.path=${deviceAction.trailingIcon}
></ha-svg-icon>
`
: ""}
</mwc-list-item>`;
return deviceAction.href
? html`<a
href=${deviceAction.href}
target=${ifDefined(
deviceAction.target
)}
.action=${deviceAction.action}
@click=${this._deviceActionClicked}
graphic="icon"
.hasMeta=${Boolean(
deviceAction.trailingIcon
rel=${ifDefined(
deviceAction.target
? "noreferrer"
: undefined
)}
>
${deviceAction.label}
${deviceAction.icon
? html`
<ha-svg-icon
class=${ifDefined(
deviceAction.classes
)}
.path=${deviceAction.icon}
slot="graphic"
></ha-svg-icon>
`
: ""}
${deviceAction.trailingIcon
? html`
<ha-svg-icon
slot="meta"
.path=${deviceAction.trailingIcon}
></ha-svg-icon>
`
: ""}
</mwc-list-item>
</a>
`
)}
>${listItem}
</a>`
: listItem;
})}
</ha-button-menu>
`
: ""}
Expand Down