Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the user-provided name when sorting devices #17297

Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Jul 13, 2023

Proposed change

#16912 caused a regression where the user-provided device name was no longer being used for filtering devices. This caused unintuitive behavior (home-assistant/core#96332) where a device present in the dropdown was not able to be selected with the displayed name:

image image

With this change, the device now shows up:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants