Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of badges after yaml dashboard change #20012

Merged
merged 2 commits into from Mar 7, 2024

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Mar 7, 2024

Proposed change

Fix for #20009

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon changed the title Badges get lost if you change using yaml Fix removal of badges after yaml change Mar 7, 2024
@silamon silamon changed the title Fix removal of badges after yaml change Fix removal of badges after yaml dashboard change Mar 7, 2024
@piitaya piitaya added this to the 2024.3 milestone Mar 7, 2024
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@piitaya piitaya merged commit 52c8554 into home-assistant:dev Mar 7, 2024
14 checks passed
bramkragten pushed a commit that referenced this pull request Mar 7, 2024
* Fix badges removed after yaml change

* Remove test code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a badge name through single dashboard YAML editor removes all badges
3 participants