More config/entities status filters #20638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I feel the current status filters are a little bit confusing/lacking in the entities table. I can understand how they came to be this way back when we used to have independent checkboxes for e.g. "show hidden entities", but now that these are presented as a filter they don't really work the same way that the other filters do, and I think this could be improved a bit.
For example, if one deselects all checkboxes and selects "Hidden", based on the behavior of the other filters one might expect it to only show the hidden entities. But instead it shows both all hidden and unhidden entities. There is no way to select only the normal/available entities either, as if you clear all the checkboxes for the exceptional states, then all entities are shown.
By adding a filter specifically for "Available", that allows us to select with more fine granularity what we want to see. (either see only available entities, or specifically hide the available entities).
I also add a filter for "Restored", just for completeness/consistency, as there are 6 statuses that we report in the status column, and that was the only last one that was missing.
This change also changes the prioritization a bit I think to behave more like other filters, given that I feel an entity can have multiple statuses, e.g. you can have a read-only + unavailable entity.
The previous behavior for a read-only unavailable entity I think was to show this only if both read-only AND unavailable were checked. Now this entity will be shown for either read-only OR unavailable is selected.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: