Add exceptional icon to weather #3572
Conversation
|
HI, following our earlier discussion, I've asked for attention to condition naming -> icon use and being more consistent in all weather sensors and platforms. please see: please have a look if it is of any use for your PR while you're at it. |
|
In the architecture issue I linked to, it was preferred to use
I personally don't support this ideal. This would create a maintainability headache, similar to what happened to the sensor platforms recently, while the weather platforms didn't need any updating, just the central component. Otherwise, the developers have to constantly follow the ever changing mdi names in several locations. |
* Alarm codes (#3566) * Handle alarm codes from keyboard input Closes #2602 * remove friendly_name changes * remove unnecessary TS check * Update azure-pipelines-release.yml for Azure Pipelines * Don't remove `hvac_action` from history attributes (#3570) So it can be used to plot a fill when active in the graph. * Update the map when making config changes (#3568) * Add haptic feedback to handle click (#3569) * Filter camera service entities (#3583) Closes #3582 * Notification drawer RTL support (#3580) * add exceptional icon (#3572) * Add options to badges (#3552) * Add options to badges name icon entity_picture * lint * lint * rename entityPicture to image * Align styling cast buttons (#3579) * Align styling cast buttons * Split dev constants * Ignore dev_const * Update README.md * Move lovelace background settings to theme (#3561) * Move lovelace background settings to theme While being backwards compatible * Also update cast * Don't allow overwrite of english lang (#3590) * Update hui-card-options.ts (#3591) * Fix display of no triggers text if no device is selected or device has no triggers (#3592) * Fix timing issue in external auth (#3587) * Fix timing issue in external auth * add await 0 * Show toast on successfull save (#3576) * Show toast on successfull save We need to make a list of places where this could benefit the user experience. * Helper method * Rename * handle unavailable lights (#3549) * handle unavailable lights * unavailable overlay * extract unavailable overlay * Option to display last changed in glance-card (#3584) * Option to display last changed in glance-card Closes home-assistant/ui-schema#110 * move show_last_changed to entity-level * address review comments * Filter alerts in services (#3598) Closes #3597 * Add exceptional in weather to translations (#3599) * Add MQTT subscribe to dev tools (#3589) * Add mqtt subscribe to dev tools * Update mqtt-subscribe-card.ts * Comments * type * Wrap long attributes in more-info-default (#3601) Can likely be applied in many other places Closes #2811 * Bumped version to 20190904.0 (#3612)
exceptionalis supposedly a supported condition for a weather platform, per home-assistant/architecture#263. However, there is no icon support for it. This PR adds a warning circle icon, as exceptional is presumably a nonstandard condition meriting a warning.The only weather platforms that have exceptional conditions are openweathermap, yweather, and nws. I can't find the documentation for the yweather codes, but openweathermap exceptional includes conditions like smoke, dust, squall, and a few undocumented ones. NWS includes conditions like tornado, hurricane, tropical storm, hot, cold, etc. I think a warning icon is appropriate for these.
Here is what it looks like for West Palm Beach Florida at the moment due to hurricane Dorian:
Edit: if this PR is welcome, I will also add
exceptionalto the dev docs.