Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes add-on audio selector #4648

Merged
merged 4 commits into from
Feb 1, 2020
Merged

Fixes add-on audio selector #4648

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
76ced7e
Fixes addon audio selector
ludeeus Jan 29, 2020
f4abd31
Set device as property
ludeeus Jan 29, 2020
9970b3a
Use getAttribute
balloob Feb 1, 2020
d7c57bf
Keep device as attribute
balloob Feb 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions hassio/src/addon-view/hassio-addon-audio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class HassioAddonAudio extends LitElement {

<paper-dropdown-menu
label="Input"
@selected-item-changed=${this._setInputDevice}
@iron-select=${this._setInputDevice}
>
<paper-listbox
slot="dropdown-content"
Expand All @@ -68,7 +68,7 @@ class HassioAddonAudio extends LitElement {
</paper-dropdown-menu>
<paper-dropdown-menu
label="Output"
@selected-item-changed=${this._setOutputDevice}
@iron-select=${this._setOutputDevice}
>
<paper-listbox
slot="dropdown-content"
Expand Down Expand Up @@ -123,14 +123,14 @@ class HassioAddonAudio extends LitElement {
}

private _setInputDevice(ev): void {
const device = ev.detail.device;
const device = ev.detail.item.getAttribute("device");
if (device) {
this._selectedInput = device;
}
}

private _setOutputDevice(ev): void {
const device = ev.detail.device;
const device = ev.detail.item.getAttribute("device");
if (device) {
this._selectedOutput = device;
}
Expand Down