New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes add-on audio selector #4648
Conversation
@@ -123,14 +123,14 @@ class HassioAddonAudio extends LitElement { | |||
} | |||
|
|||
private _setInputDevice(ev): void { | |||
const device = ev.detail.device; | |||
const device = ev.detail.item.attributes.device.value; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set device as property and use ev.detail.item.device
or use ev.detail.item.getAttribute("device")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Property looked cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but now your attr-for-selected
is missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right...
Proposed change
iron-select
instead ofselected-item-changed
to trigger_set*Device
Type of change
Example configuration
For the most part yaml is not really needed here is it?
Additional information
Checklist
How? Why? Examples, please.
If user exposed functionality or configuration variables are added/changed: