Fix resize observers and update gauge styling #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zsarnett
reviewed
May 20, 2020
| @@ -293,68 +294,70 @@ class HuiGaugeCard extends LitElement implements LovelaceCard { | |||
| round-slider { | |||
| max-width: 200px; | |||
| --round-slider-path-width: 35px; | |||
| --round-slider-path-color: var(--disabled-text-color); | |||
| --round-slider-path-color: var(--primary-background-color); | |||
There was a problem hiding this comment.
Is this right? Shouldn't it be the gray color? At least that's what it has been I thought
There was a problem hiding this comment.
Should definitely not be a text color, I think this was used before the round slider change
zsarnett
reviewed
May 20, 2020
Co-authored-by: Zack Arnett <arnett.zackary@gmail.com>
zsarnett
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The debounced function was created on every resize observation, thus not debouncing at all.
Also changes some style rules for the gauge.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: