Use Sortable to move entities in entities editor #6810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested |
bramkragten
reviewed
Sep 7, 2020
| protected render(): TemplateResult { | ||
| if (!this.entities) { | ||
| return html``; | ||
| } | ||
|
|
||
| return html` | ||
| ${sortStyles} |
There was a problem hiding this comment.
ITs a template result
There was a problem hiding this comment.
So change it to CSSResult :-)
There was a problem hiding this comment.
Should rename it anyway when we are going to use it on multiple places
There was a problem hiding this comment.
Do you know how to dynamically return styles in static get styles() ? So that we only append if this.editMode in HaSidebar?
There was a problem hiding this comment.
use
<style>
dragStyles.cssText
</style>
bramkragten
reviewed
Sep 7, 2020
bramkragten
reviewed
Sep 7, 2020
bramkragten
reviewed
Sep 7, 2020
bramkragten
approved these changes
Sep 7, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: