Use dynamic struct validation for entities card rows #9962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Currently in the entities card editor, we show a lot of false-positive warnings and errors which really confuses the users.
The reason is that as all the existing row configs were in a union and the validation logic checked them all and basically listed all combinations of potential issues. Now by using
dynamic
fromsuperstruct
we only check the config that matches thetype
of the row.=> We now only show relevant errors to the user.
Before:
There are two errors here: The mandatory
attribute
key is missing plus the not yet supportedicon
key is there. But as the YAML input is not matching any row config, we see a huge list of false-positive errors.After:
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: