Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dynamic struct validation for entities card rows #9962

Merged
merged 3 commits into from
Sep 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/structs/is-custom-type.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { refine, string } from "superstruct";

const isCustomType = (value: string) => value.startsWith("custom:");
export const isCustomType = (value: string) => value.startsWith("custom:");

export const customType = () =>
refine(string(), "custom element type", isCustomType);
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ import {
any,
array,
assert,
boolean,
assign,
boolean,
dynamic,
literal,
number,
object,
Expand All @@ -19,7 +20,10 @@ import {
union,
} from "superstruct";
import { fireEvent, HASSDomEvent } from "../../../../common/dom/fire_event";
import { customType } from "../../../../common/structs/is-custom-type";
import {
customType,
isCustomType,
} from "../../../../common/structs/is-custom-type";
import { entityId } from "../../../../common/structs/is-entity-id";
import { computeRTLDirection } from "../../../../common/util/compute_rtl";
import "../../../../components/entity/state-badge";
Expand All @@ -38,14 +42,14 @@ import "../hui-entities-card-row-editor";
import "../hui-sub-element-editor";
import { processEditorEntities } from "../process-editor-entities";
import { actionConfigStruct } from "../structs/action-struct";
import { baseLovelaceCardConfig } from "../structs/base-card-struct";
import { entitiesConfigStruct } from "../structs/entities-struct";
import {
EditorTarget,
EditSubElementEvent,
SubElementEditorConfig,
} from "../types";
import { configElementStyle } from "./config-elements-style";
import { baseLovelaceCardConfig } from "../structs/base-card-struct";

const buttonEntitiesRowConfigStruct = object({
type: literal("button"),
Expand Down Expand Up @@ -141,24 +145,53 @@ const textEntitiesRowConfigStruct = object({
icon: optional(string()),
});

const customRowConfigStruct = type({
const customEntitiesRowConfigStruct = type({
type: customType(),
});

const entitiesRowConfigStruct = union([
entitiesConfigStruct,
buttonEntitiesRowConfigStruct,
castEntitiesRowConfigStruct,
conditionalEntitiesRowConfigStruct,
dividerEntitiesRowConfigStruct,
sectionEntitiesRowConfigStruct,
webLinkEntitiesRowConfigStruct,
buttonsEntitiesRowConfigStruct,
attributeEntitiesRowConfigStruct,
callServiceEntitiesRowConfigStruct,
textEntitiesRowConfigStruct,
customRowConfigStruct,
]);
const entitiesRowConfigStruct = dynamic<any>((value) => {
if (value && typeof value === "object" && "type" in value) {
if (isCustomType((value as LovelaceRowConfig).type!)) {
return customEntitiesRowConfigStruct;
spacegaier marked this conversation as resolved.
Show resolved Hide resolved
}

switch ((value as LovelaceRowConfig).type!) {
case "attribute": {
return attributeEntitiesRowConfigStruct;
}
case "button": {
return buttonEntitiesRowConfigStruct;
}
case "buttons": {
return buttonsEntitiesRowConfigStruct;
}
case "call-service": {
return callServiceEntitiesRowConfigStruct;
}
case "cast": {
return castEntitiesRowConfigStruct;
}
case "conditional": {
return conditionalEntitiesRowConfigStruct;
}
case "divider": {
return dividerEntitiesRowConfigStruct;
}
case "section": {
return sectionEntitiesRowConfigStruct;
}
case "text": {
return textEntitiesRowConfigStruct;
}
case "weblink": {
return webLinkEntitiesRowConfigStruct;
}
}
}

// No "type" property => has to be the default entity row config struct
return entitiesConfigStruct;
});

const cardConfigStruct = assign(
baseLovelaceCardConfig,
Expand Down