Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔗 Fix broken links on our website #14663

Closed
frenck opened this issue Sep 30, 2020 · 20 comments
Closed

🔗 Fix broken links on our website #14663

frenck opened this issue Sep 30, 2020 · 20 comments
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! help-wanted Wanna help? Jump in!

Comments

@frenck
Copy link
Member

frenck commented Sep 30, 2020

The problem

Our website has been aging a bit over the last couple of years, unfortunately, this means a lot of links to external sites, have broken down. E.g., due to the website no longer exists, the page has moved and a bunch of other reasons. This is unfortunate for the users of our website.

This GitHub issue serves as a placeholder to get all those links fixed (or removed if fixing seems impossible).

Want to help us out?

Download Xenu (for free) and scan our website for broken links and help us fixing them. 👍 🎖 🎉 🍾

(Any other tool is allowed as well of course).

Notes

  • credits.markdown is a generated file. Unfortunately, we cannot fix broken links there at this moment.

Please reference this issue in your PR.
@frenck frenck added help-wanted Wanna help? Jump in! Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Sep 30, 2020
@frenck frenck pinned this issue Sep 30, 2020
@TheCoderNikhil
Copy link

can you tell me in detail what i have to do ?

@klaasnicolaas
Copy link
Member

Let's start scan again 😁

@frenck
Copy link
Member Author

frenck commented Sep 30, 2020

@klaasnicolaas I have a scan running, takes a bit.

@TheCoderNikhil Find and fix broken links as described in the issue. Is there a specific part that is not clear about that description?

@klaasnicolaas
Copy link
Member

@frenck Ehmm....Must admit that the scanner is already running here 🤣 Perhaps useful to indicate that a pull request should not be too large but also not too small? If you know what I mean 😄

@klaasnicolaas klaasnicolaas mentioned this issue Sep 30, 2020
Merged
8 tasks
@eliotw eliotw mentioned this issue Oct 1, 2020
Merged
8 tasks
This was referenced Oct 1, 2020
Merged
Merged
Merged
@klaasnicolaas klaasnicolaas mentioned this issue Oct 1, 2020
Merged
8 tasks
This was referenced Oct 1, 2020
Merged
Merged
Merged
@JeffResc
Copy link
Contributor

JeffResc commented Oct 1, 2020

Here are a few URLs that I found that I would like to leave open for someone else to fix:

Getting links from: https://www.home-assistant.io/docs/mqtt/
├─BROKEN─ https://www.home-assistant.io/cookbook/python_component_mqtt_basic/ (HTTP_404)

Getting links from: https://www.home-assistant.io/integrations/http/
├─BROKEN─ https://www.home-assistant.io/developers/python_api/ (HTTP_404)
├─BROKEN─ https://www.home-assistant.io/developers/server_sent_events/ (HTTP_404)

Getting links from: https://www.home-assistant.io/integrations/http#hosting-files
├─BROKEN─ https://www.home-assistant.io/developers/python_api/ (HTTP_404)
├─BROKEN─ https://www.home-assistant.io/developers/server_sent_events/ (HTTP_404)

This was referenced Oct 1, 2020
Merged
Merged
Closed
@stefanroelofs
Copy link
Contributor

Here are a few URLs that I found that I would like to leave open for someone else to fix:

Getting links from: https://www.home-assistant.io/docs/mqtt/
├─BROKEN─ https://www.home-assistant.io/cookbook/python_component_mqtt_basic/ (HTTP_404)

Getting links from: https://www.home-assistant.io/integrations/http/
├─BROKEN─ https://www.home-assistant.io/developers/python_api/ (HTTP_404)
├─BROKEN─ https://www.home-assistant.io/developers/server_sent_events/ (HTTP_404)

Getting links from: https://www.home-assistant.io/integrations/http#hosting-files
├─BROKEN─ https://www.home-assistant.io/developers/python_api/ (HTTP_404)
├─BROKEN─ https://www.home-assistant.io/developers/server_sent_events/ (HTTP_404)

I fixed them both. Thanks!

@stefanroelofs stefanroelofs mentioned this issue Oct 1, 2020
Merged
8 tasks
cwiggs added a commit to cwiggs/home-assistant.io that referenced this issue Oct 1, 2020
@cwiggs
Update mqtt.markdown
3ea00fd 
Fix broken link

Issue: home-assistant#14663
This was referenced Oct 1, 2020
Closed
Closed
@cwiggs
Copy link

cwiggs commented Oct 1, 2020

I've found lots of broken links in the blog, is that in scope to fix as well?

e.g.:

URL        `/integrations/automatic/'
Name       `automatic docs'
Parent URL https://www.home-assistant.io/blog/2020/05/20/release-110/, line 948, col 209
Real URL   https://www.home-assistant.io/integrations/automatic/

mbaitelman added a commit to mbaitelman/home-assistant.io that referenced this issue Oct 2, 2020
@mbaitelman
Create md-links.yml
36db961 
My team uses https://github.com/gaurav-nelson/github-action-markdown-link-check for our open source projects to address broken links in PRs before they get merged. 
Addresses home-assistant#14663
@mbaitelman mbaitelman mentioned this issue Oct 2, 2020
Closed
8 tasks
@ntilley905 ntilley905 mentioned this issue Oct 2, 2020
Merged
8 tasks
@JeffResc JeffResc mentioned this issue Oct 2, 2020
Merged
8 tasks
@klaasnicolaas klaasnicolaas mentioned this issue Oct 4, 2020
Merged
8 tasks
davet2001 pushed a commit to davet2001/home-assistant.io that referenced this issue Oct 4, 2020
@ZuluWhiskey @davet2001
Fix the link to Dwains Theme (home-assistant#14756)
e85be00 
The link to Dwains Theme had double brackets
home-assistant#14663
This was referenced Oct 5, 2020
Merged
Merged
@TopdRob TopdRob mentioned this issue Oct 5, 2020
Merged
8 tasks
TopdRob added a commit to TopdRob/home-assistant.io that referenced this issue Oct 5, 2020
@TopdRob
Fix broken links 404
71347a1 
home-assistant#14663
@TopdRob TopdRob mentioned this issue Oct 5, 2020
Merged
8 tasks
TopdRob added a commit to TopdRob/home-assistant.io that referenced this issue Oct 5, 2020
@TopdRob
Fix link to community
53640ab 
home-assistant#14663
@TopdRob TopdRob mentioned this issue Oct 5, 2020
Merged
8 tasks
TopdRob added a commit to TopdRob/home-assistant.io that referenced this issue Oct 5, 2020
@TopdRob
Fix GPIO link in blog post
49b02d1 
home-assistant#14663
@TopdRob TopdRob mentioned this issue Oct 5, 2020
Merged
8 tasks
@TychoWerner
Copy link
Contributor

TychoWerner commented Oct 5, 2020 •
edited
Loading

Image broken in post 0.28
https://www.home-assistant.io/blog/2016/09/10/notify-group-reload-api-pihole/

Link to image: https://www.home-assistant.io/images/supported_brands/automatic.png
Screenshot 2020-10-05 at 23 09 40

Which also breaks the image on https://www.home-assistant.io/blog/posts/21

@TychoWerner
Copy link
Contributor

Image is broken on 0.20
https://www.home-assistant.io/blog/2016/05/21/release-020/

Link to image: https://www.home-assistant.io/images/supported_brands/roku.png
Screenshot 2020-10-05 at 23 11 57
Which also breaks the image on https://www.home-assistant.io/blog/posts/23

@TychoWerner
Copy link
Contributor

Link in post 0.92 is broken which links to Introduction Integration
https://www.home-assistant.io/blog/2019/04/24/release-92/

Screenshot 2020-10-05 at 23 15 40

The URL 'https://www.home-assistant.io/integrations/introduction/' doesn't exist anymore.

@TychoWerner
Copy link
Contributor

Link in post 0.101 is broken which links to lifx_legacy docs
https://www.home-assistant.io/blog/2019/10/30/release-101/

Screenshot 2020-10-05 at 23 18 06

The URL 'https://www.home-assistant.io/integrations/lifx_legacy/' doesn't exist anymore.

@TychoWerner
Copy link
Contributor

Image is broken at 0.25 post
https://www.home-assistant.io/blog/2016/07/30/custom-frontend-panels-jupyter-notebooks-directv/

Screenshot 2020-10-05 at 23 19 44

Image URL is 'https://www.home-assistant.io/images/supported_brands/directv.png'

@TychoWerner
Copy link
Contributor

TychoWerner commented Oct 5, 2020 •
edited
Loading

Link in post 0.32 is broken which links to iOS
https://www.home-assistant.io/blog/2016/11/05/hacktoberfest-influxdb-weather/

Screenshot 2020-10-05 at 23 21 22

The URL 'https://www.home-assistant.io/ecosystem/ios/' doesn't exist anymore.
Which also breaks it for https://www.home-assistant.io/blog/posts/20

@TychoWerner
Copy link
Contributor

Link in post 0.34 is broken which links to nginx
https://www.home-assistant.io/blog/2016/12/03/remote-websockets-sonarr/

Screenshot 2020-10-05 at 23 24 39

The URL 'https://www.home-assistant.io/ecosystem/nginx/' doesn't exist anymore.
Which also breaks it for https://www.home-assistant.io/blog/posts/20

@klaasnicolaas klaasnicolaas mentioned this issue Oct 5, 2020
Merged
8 tasks
frenck pushed a commit that referenced this issue Oct 6, 2020
@TopdRob
Fix broken links 404 (#14934)
7c995ca 
#14663
frenck pushed a commit that referenced this issue Oct 6, 2020
@TopdRob
Fix link to community (#14935)
82d5a8b 
#14663
frenck pushed a commit that referenced this issue Oct 6, 2020
@TopdRob
Fix GPIO link in blog post (#14936)
7e242f0 
#14663
@stefanroelofs stefanroelofs mentioned this issue Oct 7, 2020
Closed
8 tasks
@1DontEx1st 1DontEx1st mentioned this issue Oct 21, 2020
Merged
5 tasks
This was referenced Oct 27, 2020
Merged
Merged
Closed
@frenck
Copy link
Member Author

frenck commented Nov 8, 2020

Closing this issue, as Hacktoberfest is over!

@frenck frenck closed this as completed Nov 8, 2020
@frenck frenck unpinned this issue Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! help-wanted Wanna help? Jump in!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create md-links.yml mbaitelman/home-assistant.io
8 participants
@frenck @cwiggs @JeffResc @klaasnicolaas @TychoWerner @ZuluWhiskey @stefanroelofs @TheCoderNikhil