Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update synology_srm component to use the new config flow workflow #13368

Closed

Conversation

aerialls
Copy link
Contributor

@aerialls aerialls commented May 9, 2020

Proposed change

Update the documentation to reflect changes for the Synology SRM component.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • [] Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels May 9, 2020
@frenck frenck added this to To Do in New documentation via automation May 12, 2020
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label May 12, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @aerialls! 👍

I've reviewed it and left some comments. Could you please take a look?

Thanks 👍

source/_integrations/synology_srm.markdown Outdated Show resolved Hide resolved
source/_integrations/synology_srm.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label May 12, 2020
@project-bot project-bot bot moved this from To Do to In Progress in New documentation May 12, 2020
@aerialls
Copy link
Contributor Author

aerialls commented May 12, 2020

Hello @frenck, thanks for the feedback! I've updated my PR with your remarks.

@aerialls
Copy link
Contributor Author

Hello @frenck. Did you have time to review my changes and also the main PR on core? Thanks!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

New documentation automation moved this from In Progress to Awaiting Parent PR Jun 1, 2020
@frenck frenck added awaits-parent Awaits the merge of an parent PR and removed in-progress This PR/Issue is currently being worked on labels Jun 1, 2020
@frenck
Copy link
Member

frenck commented Aug 3, 2020

Closing PR as the parent PR has been closed.

@frenck frenck closed this Aug 3, 2020
New documentation automation moved this from Awaiting Parent PR to Done Aug 3, 2020
@probot-home-assistant probot-home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants