Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for the new growatt_rs232 integration #13991

Closed
wants to merge 2 commits into from
Closed

Docs for the new growatt_rs232 integration #13991

wants to merge 2 commits into from

Conversation

ArdescoConsulting
Copy link

@ArdescoConsulting ArdescoConsulting commented Jul 13, 2020 •
edited by klaasnicolaas

Proposed change

⚠️ This is the documentation for the new growatt_rs232 integration I'm going to PR soon in the code repo.

New Growatt integration thats uses RS232 modbus i.s.o. the Growatt cloud service.

Type of change

New Documentation

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

This is my first integration so kindly point me in the right direction if something is missing ;)

@probot-home-assistant probot-home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jul 13, 2020
@probot-home-assistant probot-home-assistant bot added the next This PR goes into the next branch label Jul 13, 2020
@klaasnicolaas klaasnicolaas added the new-integration This PR adds documentation for a new Home Assistant integration label Jul 13, 2020
@klaasnicolaas
Copy link
Member

Please rebase the branch on your fork to the next branch and push again.

@klaasnicolaas klaasnicolaas added this to To Do in New documentation via automation Jul 13, 2020
@ArdescoConsulting
Copy link
Author

@klaasnicolaas
This is my first PR so I don't really know how to do rebase the branch on your fork to the next branch and push again.
I saw that I have to correct the text (usb -> USB)
Thanks

@klaasnicolaas klaasnicolaas self-assigned this Jul 13, 2020
@klaasnicolaas
Copy link
Member

Give me a minute, I will perform the rebase for you 😉

@ArdescoConsulting @klaasnicolaas
Create growatt_rs232.markdown
10cc170 
This is the help for the new growatt_rs232 integration I'm going to PR soon.
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jul 13, 2020
@klaasnicolaas klaasnicolaas removed their assignment Jul 13, 2020
@klaasnicolaas
Copy link
Member

klaasnicolaas commented Jul 13, 2020 •
edited

Rebase is done, please fix the other Lint errors

@klaasnicolaas klaasnicolaas moved this from To Do to In Progress in New documentation Jul 13, 2020
@klaasnicolaas klaasnicolaas changed the title Patch 1 Docs for new growatt_rs232 integration Jul 13, 2020
@probot-home-assistant probot-home-assistant bot added the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jul 13, 2020
@klaasnicolaas klaasnicolaas changed the title Docs for new growatt_rs232 integration Docs for the new growatt_rs232 integration Jul 13, 2020
@klaasnicolaas klaasnicolaas removed the needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch label Jul 13, 2020
@klaasnicolaas klaasnicolaas removed their assignment Jul 13, 2020
@ArdescoConsulting
Copy link
Author

OK thanks.
The Lint errors are fixed.

@ArdescoConsulting ArdescoConsulting mentioned this pull request Jul 14, 2020
Closed
16 tasks
@probot-home-assistant probot-home-assistant bot added the has-parent This PR has a parent PR in a other repo label Jul 14, 2020
@frenck
Copy link
Member

frenck commented Sep 30, 2020

closing PR as the parent has been closed.

@frenck frenck closed this Sep 30, 2020
New documentation automation moved this from In Progress to Done Sep 30, 2020
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ArdescoConsulting ArdescoConsulting

Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
No open projects
New documentation
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArdescoConsulting @klaasnicolaas @frenck