Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OZW docs for new config parameter type and provide example #14793

Merged
merged 5 commits into from
Oct 20, 2020

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Oct 2, 2020

Proposed change

My parent PR adds support for a new parameter type for the set_config_parameter service, so this PR updates the docs to instruct users on how to use the service for that type.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 2, 2020
@frenck frenck added this to Ready for review in Content improvements via automation Oct 2, 2020
@frenck frenck added this to To Do in New documentation via automation Oct 2, 2020
@frenck frenck removed this from Ready for review in Content improvements Oct 2, 2020
New documentation automation moved this from To Do to Awaiting Parent PR Oct 2, 2020
frenck
frenck previously approved these changes Oct 2, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Oct 2, 2020
@raman325
Copy link
Contributor Author

raman325 commented Oct 2, 2020

Thanks @frenck I am going to close this for now and re-open it against a new PR. Turns out I did not implement the change documented here correctly so will have to submit a PR to fix

@raman325 raman325 closed this Oct 2, 2020
New documentation automation moved this from Awaiting Parent PR to Done Oct 2, 2020
@probot-home-assistant probot-home-assistant bot added Invalid and removed awaits-parent Awaits the merge of an parent PR Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 2, 2020
@raman325 raman325 reopened this Oct 4, 2020
New documentation automation moved this from Done to To Do Oct 4, 2020
@raman325
Copy link
Contributor Author

raman325 commented Oct 4, 2020

This change was reintroduced into the parent PR but the schema is different. PR updated accordingly

@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Oct 5, 2020
@project-bot project-bot bot moved this from To Do to Parent Merged in New documentation Oct 5, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @raman325 👍

New documentation automation moved this from Parent Merged to Awaiting Parent PR Oct 20, 2020
@frenck frenck merged commit 410b142 into home-assistant:next Oct 20, 2020
New documentation automation moved this from Awaiting Parent PR to Done Oct 20, 2020
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Oct 20, 2020
@raman325 raman325 deleted the ozw_set_config_parameter branch March 3, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo Invalid next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants