Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plant domain to the group integration #15239

Merged
merged 1 commit into from Oct 15, 2020

Conversation

McGiverGim
Copy link
Contributor

@McGiverGim McGiverGim commented Oct 14, 2020

Proposed change

The plant support in groups was removed and added again later here: home-assistant/core#41519
The documentation was not updated to reflect this change.

I used the UI of Github for this change, and it modifies too the latest line in the file, I don't know if this is a problem.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 14, 2020
@probot-home-assistant probot-home-assistant bot added current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 14, 2020
@McGiverGim
Copy link
Contributor Author

Is my first PR to Home Assistant, I'm not too sure why it needs rebase. I'm up to date with the origin current branch.

@frenck frenck added this to To Do in New documentation via automation Oct 15, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is based off, and targeting the wrong branch. As this documentation change depends on a parent PR in the codebase, it mean this documentation change only applies when a next version of Home Assistant is released.

Hence it should target the next branch. Please change the target and git rebase if needed.

@McGiverGim
Copy link
Contributor Author

Thanks @frenck, maybe I have marked the wrong options.

This change applies to the current version. The parent PR that I linked was merged into 0.116.2, but simply the documentation was not updated.

After that, do you think is better to target it for the next branch?

New documentation automation moved this from To Do to Awaiting Parent PR Oct 15, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @McGiverGim 👍

You are absolutely right! Merging this to current is indeed the correct move in this case.

Happy Hacktoberfest 🎉

@frenck frenck merged commit 85dda11 into home-assistant:current Oct 15, 2020
New documentation automation moved this from Awaiting Parent PR to Done Oct 15, 2020
@probot-home-assistant probot-home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants