Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to notify users how to fix missing device in options flow #15331

Merged
merged 1 commit into from Oct 20, 2020

Conversation

RobBie1221
Copy link
Contributor

Proposed change

Add a warning how to fix when a device is missing from the device list in the options flow.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 20, 2020
@RobBie1221
Copy link
Contributor Author

Parent has actually been merged. Better late than never...
I think it's in place to put a warning in the docs how users can fix it when a device is missing from the device list in the options flow instead of asking them to find the core PR to see the notes there.

@frenck frenck added this to To Do in New documentation via automation Oct 20, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Oct 20, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RobBie1221 👍

New documentation automation moved this from To Do to Awaiting Parent PR Oct 20, 2020
@frenck frenck merged commit 77a4bfb into home-assistant:next Oct 20, 2020
New documentation automation moved this from Awaiting Parent PR to Done Oct 20, 2020
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Oct 20, 2020
@RobBie1221 RobBie1221 deleted the rfxtrx_warn_options branch October 21, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants