Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Colored Flash Example to deCONZ #15705

Merged
merged 4 commits into from Nov 23, 2020
Merged

Add Colored Flash Example to deCONZ #15705

merged 4 commits into from Nov 23, 2020

Conversation

D34DC3N73R
Copy link
Contributor

Proposed change

Update documentation with an example of colored flashing of hue bulbs via deconz.configure as a workaround since the light.turn_on service with flash:long|short and color does not work with deCONZ.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Colored flashing of hue bulbs via `deconz.configure` as a workaround since the `light.turn_on` service with `flash:long|short` and `color` does not work with deCONZ
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Nov 20, 2020
@Kane610 Kane610 changed the title Add Colored Flash Example Add Colored Flash Example to deCONZ Nov 21, 2020
Kane610
Kane610 previously approved these changes Nov 21, 2020
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for contributing. Looks good to me

`field:` is not allowed in scripts, so updated to (and tested) automation
@D34DC3N73R
Copy link
Contributor Author

Ok so, I think the original script example had some errors. It should use entity instead of entity_id if I'm not mistaken, and entity should be in the first data: of the service call. I thought the nested data: lines were an error too but it turns out it's required so field can be included. I couldn't get the script to run correctly at first so I changed the example to an automation.

The replacement automation example works too. But IMO, this updated script may be a better example with less extraneous detail.

script:
  hue_lamp_flash:
    alias: Hue Lamp Flash
    sequence:
    - service: deconz.configure
      data:
        field: /state
        data:
          'on': true
          hue: 65535
          sat: 255
          bri: 255
          alert: breathe
        entity: light.hue_lamp
    - delay: '15'
    - service: deconz.configure
      data:
        field: /state
        data:
          'on': false
        entity: light.hue_lamp
    mode: single

Sorry for the runaround. Let me know if you'd like this to be submitted as another commit, or even as a separate PR.

@frenck frenck added this to Ready for review in Content improvements via automation Nov 21, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not documenting flashing but a breathing flash effect, which is kinda Philips specific. I think we need to be clear on the difference in the description.

source/_integrations/deconz.markdown Show resolved Hide resolved
source/_integrations/deconz.markdown Outdated Show resolved Hide resolved
source/_integrations/deconz.markdown Outdated Show resolved Hide resolved
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Nov 21, 2020
@frenck frenck moved this from Ready for review to In progress in Content improvements Nov 21, 2020
@frenck frenck removed their request for review November 22, 2020 19:50
@frenck
Copy link
Member

frenck commented Nov 22, 2020

removed the review request, as my original suggestion in the review comment wasn't resolved.

@D34DC3N73R
Copy link
Contributor Author

I updated the Note: line to include Philips Hue by name.
alert: breathe is what hue bridge uses with service light.turn_on and flash, so I think it makes sense to keep that description for users looking for a replacement.

Removed raw/endraw tags and updated Note text to differentiate variables from standard copy. As well as adding a line about converting the example to work with light groups.
Content improvements automation moved this from In progress to Reviewer approved Nov 23, 2020
@frenck
Copy link
Member

frenck commented Nov 23, 2020

Thanks 👍

@frenck frenck merged commit 58a5c8f into home-assistant:current Nov 23, 2020
Content improvements automation moved this from Reviewer approved to Done Nov 23, 2020
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Nov 23, 2020
@D34DC3N73R D34DC3N73R deleted the patch-1 branch November 23, 2020 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants