Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid time pattern for "every hour" example #18100

Merged
merged 1 commit into from Jun 7, 2021
Merged

Fix invalid time pattern for "every hour" example #18100

merged 1 commit into from Jun 7, 2021

Conversation

kylehase
Copy link
Contributor

@kylehase kylehase commented Jun 6, 2021

Proposed change

The example for the "every hour" trigger uses an invalid time pattern format minutes: "/60" which throws the following error.

Invalid config for [automation]: must be a value between 0 and 59 for dictionary value @ data['minutes']

Propose replacing it with hours: "*"

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • The documentation follows the Home Assistant documentation standards.

@kylehase
Fix invalid time pattern for "every hour" example
e60078a 
The example for the "every hour" trigger uses an invalid time pattern format - minutes: "/60" - which throws the following error.
 
> Invalid config for [automation]: must be a value between 0 and 59 for dictionary value @ data['minutes']
 
Propose replacing it with - hours: "*"
@homeassistant
Copy link

Hi @kylehase,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jun 6, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jun 7, 2021
Content improvements automation moved this from Ready for review to Reviewer approved Jun 7, 2021
frenck
frenck approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kylehase 👍

@frenck frenck merged commit 22fc6e4 into home-assistant:current Jun 7, 2021
Content improvements automation moved this from Reviewer approved to Done Jun 7, 2021
@kylehase kylehase deleted the patch-1 branch June 7, 2021 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Content improvements
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylehase @homeassistant @frenck