Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting the easiest method at the top #18175

Merged
merged 2 commits into from Jun 15, 2021

Conversation

AalianKhan
Copy link
Contributor

Proposed change

by far the easiest method to retrieve the access token is to use the get mi home devices app so to avoid people getting confused and use the harder method I have moved the easier method at the top. Personally, I think if there was an accordion to hide the alternative ways to retrieve the token it will make the page much cleaner as there are lots of methods but the user only needs 1 way to retrieve the token.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

by far the easiest method to retrieve the access token is to use the get mi home devices app so to avoid people getting confused and use the harder method I have moved the easier method at the top. Personally, I think if there was an accordion to hide the alternative ways to retrieve the token it will make the page much cleaner as there are lots of methods but the user only needs 1 way to retrieve the token.
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jun 13, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Jun 15, 2021
frenck
frenck previously approved these changes Jun 15, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @AalianKhan 👍

The good news is: For Home Assistant 2021.7 (next release) this all can be removed, as Home Assistant will handle this for you. 🎉

../Frenck

Content improvements automation moved this from Ready for review to Reviewer approved Jun 15, 2021
@frenck frenck merged commit 62e4bc8 into home-assistant:current Jun 15, 2021
Content improvements automation moved this from Reviewer approved to Done Jun 15, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants