Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar.markdown #19132

Closed
wants to merge 2 commits into from
Closed

Update sidebar.markdown #19132

wants to merge 2 commits into from

Conversation

benblb
Copy link

@benblb benblb commented Aug 30, 2021

Added info on where to find the option to enable sidebar. Really struggled to enable it and wanted to contribute to hopefully help someone else.

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • [x ] Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Added info on where to find the option to enable sidebar. Really struggled to enable it and wanted to contribute to hopefully help someone else.
@homeassistant
Copy link

Hi @benblb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Aug 30, 2021
Instruction for creating a new sidebar view, not editing a current view to become sidebar.
@balloob
Copy link
Member

balloob commented Sep 4, 2021

I don't think that this change makes sense. There are 5 inputs on that form, one of them is "View Type", no need to specify "at the bottom".

It's also added to a sentence that talks about "editing", not creating new.

@balloob balloob closed this Sep 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants