Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger.markdown #19476

Merged
merged 4 commits into from Feb 22, 2022
Merged

Update trigger.markdown #19476

merged 4 commits into from Feb 22, 2022

Conversation

finity69x2
Copy link
Contributor

@finity69x2 finity69x2 commented Sep 26, 2021

Add warnings to be considered when using the "for:" option.

Proposed change

The use of the "for:" option in automation triggers doesn't survive server restarts or automation reloading. This results in unexpected behavior if the user relies on the trigger to occur at the time specified. This is a big reliability concern when used and the user is unaware of this behavior.

If the underlying behavior can't be corrected then at a minimum there should be a warning in the documentation pointing out this limitation especially for time critical automation triggers.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue:

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Sep 26, 2021
@frenck frenck added this to Ready for review in Content improvements via automation Sep 26, 2021
@frenck frenck added the in-progress This PR/Issue is currently being worked on label Sep 26, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 26, 2021
@frenck frenck self-requested a review January 5, 2022 23:00
Content improvements automation moved this from Ready for review to Reviewer approved Feb 22, 2022
@frenck frenck merged commit c553eb1 into home-assistant:current Feb 22, 2022
Content improvements automation moved this from Reviewer approved to Done Feb 22, 2022
@probot-home-assistant probot-home-assistant bot removed the in-progress This PR/Issue is currently being worked on label Feb 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch smash Indicator this PR is close to finish for merging or closing
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants