New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update trigger.markdown #19476
Merged
Merged
Update trigger.markdown #19476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenck
requested changes
Sep 26, 2021
frenck
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Oct 26, 2021
frenck
reviewed
Feb 18, 2022
frenck
reviewed
Feb 22, 2022
frenck
reviewed
Feb 22, 2022
Add warnings to be considered when using the "for:" option.
frenck
approved these changes
Feb 22, 2022
probot-home-assistant
bot
removed
the
in-progress
This PR/Issue is currently being worked on
label
Feb 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
current
This PR goes into the current branch
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warnings to be considered when using the "for:" option.
Proposed change
The use of the "for:" option in automation triggers doesn't survive server restarts or automation reloading. This results in unexpected behavior if the user relies on the trigger to occur at the time specified. This is a big reliability concern when used and the user is unaware of this behavior.
If the underlying behavior can't be corrected then at a minimum there should be a warning in the documentation pointing out this limitation especially for time critical automation triggers.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.