Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint about multiple nic in same subnet for Synology DSM #23025

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jun 6, 2022

Proposed change

There were multiple issues in the past (home-assistant/core/issues/59153, home-assistant/core/issues/69709, home-assistant/core/issues/73140), which were all caused by configuring multiple NICs in same subnet and having SSDP enabled, instead of using NIC bonding. This will add a hint/note about this.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@mib1185 mib1185 requested a review from Quentame as a code owner June 6, 2022 20:29
@probot-home-assistant probot-home-assistant bot added the current This PR goes into the current branch label Jun 6, 2022
@frenck frenck added this to Ready for review in Content improvements via automation Jun 7, 2022
Content improvements automation moved this from Ready for review to Reviewer approved Jun 7, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

@frenck frenck merged commit d998106 into home-assistant:current Jun 7, 2022
Content improvements automation moved this from Reviewer approved to Done Jun 7, 2022
@mib1185 mib1185 deleted the synology_dsm/add-hint-about-multiple-nic-in-same-subnet branch June 7, 2022 10:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed current This PR goes into the current branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants