Document use of Persistent Notification as a notifier #23336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
the
has-parent
23 tasks
deviantintegral
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Some comments, but honestly neither seems like a required change. Everything looks good to me at https://deploy-preview-23336--home-assistant-docs.netlify.app/integrations/persistent_notification/#use-as-a-notifier
source/_integrations/notify.markdown
Outdated
Comment on lines
16
to
17
| If you want to send notifications to the Home Assistant web interface, you may use the [Persistent Notification integration](/integrations/persistent_notification/). The Persistent Notification integration is also available as a automatically configured notifier. See its documentation for more details. | ||
|
|
There was a problem hiding this comment.
How about linking See its documentation to the Use as a notifier heading?
frenck
reviewed
Jun 27, 2023
frenck
reviewed
Jun 27, 2023
frenck
approved these changes
Jun 27, 2023
home-assistant
bot
removed
the
parent-merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds documentation for using the Persistent Notification integration as a notifier. This was never actually documented back when the feature was added (my fault), and the linked PR is updating it to support
notification_idin thedatasection which needs to be documented, which means i need to fix the previous omission, and document the new parameter.While the code actually lives in the
notifyintegration, it is documented with thepersistent_notificationintegration to better match how all other notifies are documented, and because the implementation location is is not supposed to be a user visible detail.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.