Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change snapcast from polling to push type #27390

Merged
merged 1 commit into from
May 23, 2023
Merged

Change snapcast from polling to push type #27390

merged 1 commit into from
May 23, 2023

Conversation

luar123
Copy link
Contributor

@luar123 luar123 commented May 13, 2023 •
edited

Proposed change

Change from polling to push

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@luar123
Update snapcast.markdown
526cb3d 
Change from polling to push
@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels May 13, 2023
@luar123 luar123 mentioned this pull request May 13, 2023
Closed
20 tasks
@luar123 luar123 changed the title Update snapcast.markdown Change snapcast from polling to push type May 13, 2023
@luar123 luar123 marked this pull request as draft May 15, 2023 11:54
@luar123 luar123 mentioned this pull request May 15, 2023
Merged
20 tasks
@luar123 luar123 marked this pull request as ready for review May 15, 2023 17:02
frenck
frenck approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label May 21, 2023
@frenck frenck merged commit d67aaa0 into home-assistant:next May 23, 2023
8 checks passed
@home-assistant home-assistant bot removed the awaits-parent Awaits the merge of an parent PR label May 23, 2023
@luar123 luar123 deleted the snapcast_push branch May 23, 2023 11:24
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luar123 @frenck