Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date platform and improve other text of Vallox integration #31609

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

yozik04
Copy link
Contributor

@yozik04 yozik04 commented Feb 25, 2024

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 25, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

Copy link

netlify bot commented Feb 25, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 28d9b22
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/65e58e6137df6f0008bf0752
😎 Deploy Preview https://deploy-preview-31609--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yozik04 yozik04 changed the base branch from current to next February 25, 2024 16:45
@yozik04 yozik04 requested review from a team, bachya and joostlek as code owners February 25, 2024 16:45
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Feb 25, 2024
@home-assistant home-assistant bot added the next This PR goes into the next branch label Feb 25, 2024
@yozik04 yozik04 changed the title Add button platform and improve other text. Add date platform and improve other text. Feb 26, 2024
@joostlek joostlek removed request for bachya, joostlek and a team February 26, 2024 11:32
@yozik04
Copy link
Contributor Author

yozik04 commented Feb 26, 2024

I am sorry, but PR review ended up with button -> date platform change.

@klaasnicolaas klaasnicolaas added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration and removed in-progress This PR/Issue is currently being worked on labels Mar 1, 2024
@klaasnicolaas klaasnicolaas changed the title Add date platform and improve other text. Add date platform and improve other text of Vallox integration Mar 1, 2024
@home-assistant
Copy link

home-assistant bot commented Mar 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 1, 2024 01:31
@joostlek joostlek added the parent-merged The parent PR has been merged already label Mar 1, 2024
@yozik04 yozik04 marked this pull request as ready for review March 1, 2024 19:40
@yozik04
Copy link
Contributor Author

yozik04 commented Mar 1, 2024

I am not sure if I got your point correctly, but this is what I have now. Previously it was more compact that I liked.

@klaasnicolaas
Copy link
Member

This is fine, it is less compact but it will appear neatly in the TOC (table of contents) and you can use a hyperlink directly to part of the docs via the markdown header.

./Klaas

klaasnicolaas
klaasnicolaas previously approved these changes Mar 1, 2024
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yozik04 👍

@c0ffeeca7 c0ffeeca7 added this to the 2024.3 milestone Mar 4, 2024
@c0ffeeca7 c0ffeeca7 merged commit c67a7d8 into home-assistant:next Mar 4, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Mar 4, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked This PR has been manually picked and merged into the current branch has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants