Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration docs for APsystems API #32096

Merged
merged 12 commits into from
May 20, 2024
Merged

Conversation

mawoka-myblock
Copy link

@mawoka-myblock mawoka-myblock commented Mar 30, 2024

Proposed change

Adds integration docs

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Mar 30, 2024
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 56e8bd4
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/664b1cafd22d550008548a78
😎 Deploy Preview https://deploy-preview-32096--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joostlek joostlek added the parent-merged The parent PR has been merged already label May 15, 2024
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 16, 2024 09:48
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 18, 2024 17:09
@home-assistant home-assistant bot requested a review from c0ffeeca7 May 18, 2024 17:09
@mawoka-myblock
Copy link
Author

Thanks. I've commented the code out, as this will be added soon when I finish the other PRs in the core.

@c0ffeeca7
Copy link
Contributor

Thanks. I've commented the code out, as this will be added soon when I finish the other PRs in the core.

ah, I was just going to ask about the comments. Please remove them from this PR, if they are related to changes from other core PRs.

@mawoka-myblock
Copy link
Author

Okay, removed the comments

source/_integrations/apsystems.markdown Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 20, 2024 08:50
@home-assistant home-assistant bot requested a review from c0ffeeca7 May 20, 2024 08:50
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label May 20, 2024
@mawoka-myblock
Copy link
Author

Why did you close the PR?

@frenck frenck reopened this May 20, 2024
@frenck
Copy link
Member

frenck commented May 20, 2024

Why did you close the PR?

I didn't. You did in home-assistant/core#117782

CleanShot 2024-05-20 at 11 15 29@2x

You marked this PR to be closed by GitHub when that one would be merged by assign the fixes keyword in front of the PR.

../Frenck

@mawoka-myblock
Copy link
Author

Oh! I didn't know that and also didn't expect that, as I've just linked to a comment in this PR, not to the PR itself.

Co-authored-by: c0ffeeca7 <38767475+c0ffeeca7@users.noreply.github.com>
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more tiny nitpicks.

source/_integrations/apsystems.markdown Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
source/_integrations/apsystems.markdown Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 20, 2024 09:40
@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 20, 2024 09:49
@home-assistant home-assistant bot requested a review from c0ffeeca7 May 20, 2024 09:49
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you, @mawoka-myblock 👍

@mawoka-myblock
Copy link
Author

No problem, thank you for your nice feedback and all the commit suggestions below immediately! Really appreciate that!

@c0ffeeca7 c0ffeeca7 merged commit d5d3d9a into home-assistant:next May 20, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants