Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API Key instructions from Hydrawise docs #32488

Merged
merged 1 commit into from
May 5, 2024

Conversation

dknowles2
Copy link
Contributor

@dknowles2 dknowles2 commented Apr 27, 2024

Proposed change

Remove the prerequisites section from the Hydrawise docs that discuss the need to obtain an API Key. This is no longer necessary with home-assistant/core#106904 as you can now simply authenticate using username & password.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Apr 27, 2024
Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 6063caa
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6637aed377f03b0008c50e87
😎 Deploy Preview https://deploy-preview-32488--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joostlek
Copy link
Member

joostlek commented May 5, 2024

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

@arohl
Copy link

arohl commented May 5, 2024

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

I note that because I authenticate via Apple, I don’t have a password. Does this mean I have to create a new account using my email address to use this integration now? Or is there some way to get the authentication dialog in the integration linked to the Apple authentication page?

@dknowles2 dknowles2 changed the base branch from next to current May 5, 2024 16:06
@dknowles2 dknowles2 requested a review from a team as a code owner May 5, 2024 16:06
@home-assistant home-assistant bot removed the next This PR goes into the next branch label May 5, 2024
@home-assistant home-assistant bot added current This PR goes into the current branch in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 5, 2024
@home-assistant
Copy link

home-assistant bot commented May 5, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@dknowles2
Copy link
Contributor Author

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

Done.

@dknowles2
Copy link
Contributor Author

Let's rebase this to current so we can get this in. If you ever notice that we forget to merge the docs (or label it for that matter) but the feature did, be sure to let us know on discord :)

I note that because I authenticate via Apple, I don’t have a password. Does this mean I have to create a new account using my email address to use this integration now? Or is there some way to get the authentication dialog in the integration linked to the Apple authentication page?

Let's discuss in home-assistant/core#116830 (comment)

@dknowles2 dknowles2 removed their assignment May 5, 2024
Copy link
Member

@klaasnicolaas klaasnicolaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnx for making the changes in the docs 👍🏻

@klaasnicolaas klaasnicolaas removed in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels May 5, 2024
@klaasnicolaas klaasnicolaas merged commit 7bc5f56 into home-assistant:current May 5, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label May 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants