Update to auto turn off the cycle #3391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of service_template to automatically turn off the cycle when the lights reach their minimum or maximum brightness. Validated on my own lights.
fabaff
requested changes
Sep 17, 2017
| script.turn_on | ||
| {% else %} | ||
| script.turn_off | ||
| {% endif %} |
There was a problem hiding this comment.
To avoid render of the template, use {% raw %}{{your_template}}{% endraw %}.
| script.turn_on | ||
| {% else %} | ||
| script.turn_off | ||
| {% endif %} |
Added the raw/endraw tags to the half I missed
|
@fabaff The PR was updated, could you please take a look and revisit your review? Thx! |
fabaff
approved these changes
Oct 18, 2017
fabaff
pushed a commit
that referenced
this pull request
Oct 21, 2017
* Update to auto turn off the cycle Addition of service_template to automatically turn off the cycle when the lights reach their minimum or maximum brightness. Validated on my own lights. * Fixed facepalm Added the raw/endraw tags to the half I missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of service_template to automatically turn off the cycle when the lights reach their minimum or maximum brightness. Validated on my own lights.