Ads #4115
Merged
Ads #4115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 18, 2017 18:07
|
@MrLeeH Please specify the related parent PR in the start post. |
6 tasks
MartinHjelmare
requested changes
Dec 5, 2017
source/_components/ads.markdown
Outdated
|
|
||
| {% configuration %} | ||
|
|
||
| - **device** (*Required*): The AMS NetId that identifies the device. |
There was a problem hiding this comment.
This should be written using a kind of yaml syntax. See:
https://raw.githubusercontent.com/home-assistant/home-assistant.github.io/next/source/_components/dominos.markdown
|
|
||
| {% configuration %} | ||
|
|
||
| - **adsvar** (*Required*): The name of the variable which you want to access on |
|
|
||
| {% configuration %} | ||
|
|
||
| - **adsvar** (*Required*): The name of the boolean variable that switches the |
|
|
||
| {% configuration %} | ||
|
|
||
| - **adsvar** (*Required*): The name of the variable which you want to access on |
There was a problem hiding this comment.
is there a default keyword for default values or should I just add the default value to the description?
There was a problem hiding this comment.
There is a default key, so use that, 👍.
| Configuration variables: | ||
|
|
||
| {% configuration %} | ||
| - **adsvar** (*Required*): The name of the variable which you want to access on |
source/_components/ads.markdown
Outdated
| footer: true | ||
| logo: home-assistant.png | ||
| ha_category: Hub | ||
| ha_release: 0.59 |
| footer: true | ||
| logo: home-assistant.png | ||
| ha_category: Binary Sensor | ||
| ha_release: 0.59 |
| footer: true | ||
| logo: home-assistant.png | ||
| ha_category: Light | ||
| ha_release: 0.59 |
| footer: true | ||
| logo: home-assistant.png | ||
| ha_category: Sensor | ||
| ha_release: 0.59 |
| footer: true | ||
| logo: home-assistant.png | ||
| ha_category: Switch | ||
| ha_release: 0.59 |
| name: | ||
| required: false | ||
| description: An identifier for the sensor | ||
| factor: |
There was a problem hiding this comment.
name (the key above factor) is missing the type key-value pair.
| factor: | ||
| required: false | ||
| description: A factor that divides the stored value before displaying in Home Assistant | ||
| default: 1 | ||
| {% endconfiguration %} |
There was a problem hiding this comment.
No type here for factor either.
| adsvar: | ||
| required: true | ||
| description: The name of the variable which you want to access on the ADS device | ||
| name: |
tschmidty69
pushed a commit
to tschmidty69/home-assistant.github.io
that referenced
this pull request
Dec 9, 2017
* add ads hub and switch * add ads binary sensor * add ADS sensor * fix version numbers * separate configuration tag * remove device notification config * fix configuration schema. * replace tabs with spaces * add type key-value-pairs
tschmidty69
pushed a commit
to tschmidty69/home-assistant.github.io
that referenced
this pull request
Dec 10, 2017
* add ads hub and switch * add ads binary sensor * add ADS sensor * fix version numbers * separate configuration tag * remove device notification config * fix configuration schema. * replace tabs with spaces * add type key-value-pairs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refers to closed PR #3777.
Add documentation for new ADS component.
Pull request in home-assistant (if applicable):
home-assistant/core#10142
Checklist:
current. New documentation for platforms/components and features should go tonext.