-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Tahoma Lighting Receiver on/off io #15925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Fix the lint issue and we can merge.
_LOGGER.debug("Turn off: %s", self._name) | ||
if self.tahoma_device.type == 'rts:GarageDoor4TRTSComponent': | ||
return | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This else
can be removed since there's a return statement above.
Else removed, but where is the lint issue? tox and pylint did not show anything. |
Travis pylint job failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Can be merged when build passes. |
Description:
Add support for Tahoma Lighting Receiver on/off io
Checklist:
tox
.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices: