-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[climate] Add water_heater to evohome #25035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. The only point to solve is datetime handling 👍
@balloob I'm not intending to make any more changes to this, if you'd like to merge it. I has essentially passed QI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I did make one change and moved conversion to local datetime next to where we send it out to the lib. Generally, we don't want to have any non-UTC timestamps pass through any of our code, because it leads to confusion.
Woot! 💐 Thanks everyone! |
* initial commit * refactor for sync * minor tweak * refactor convert code * fix regression * remove bad await * de-lint * de-lint 2 * address edge case - invalid tokens * address edge case - delint * handle no schedule * improve support for RoundThermostat * tweak logging * delint * refactor for greatness * use time_zone: for state attributes * small tweak * small tweak 2 * have datetime state attributes as UTC * have datetime state attributes as UTC - delint * have datetime state attributes as UTC - tweak * missed this - remove * de-lint type hint * use parse_datetime instead of datetime.strptime) * remove debug code * state atrribute datetimes are UTC now * revert * de-lint (again) * tweak type hints * de-lint (again, again) * tweak type hints * Convert datetime closer to sending it out
Breaking Change:
Description:
Adds water_heater to evohome - this is required to support those moving from honeywell, which has deprecated EU support.
Also switches a lot of async to sync.
Also addresses:
KeyError
Exception for systems with DHW controllersRelated issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: