Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added states and modes for zwave climate #25274

Merged
merged 4 commits into from Jul 18, 2019

Conversation

@stboch
Copy link
Contributor

commented Jul 18, 2019

Description:

Added support for Fan Only State @balloob
Added additional missing modes and states this should correct issue #25216
Related issue (if applicable): fixes #25216

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
Update climate.py
Added support for Fan Only State
Added additional missing modes and states this should correct issue #25216

@stboch stboch requested a review from home-assistant/z-wave as a code owner Jul 18, 2019

@ghost

This comment has been minimized.

Copy link

commented Jul 18, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@dshokouhi
Copy link
Contributor

left a comment

Small typo :)

homeassistant/components/zwave/climate.py Outdated Show resolved Hide resolved
@cgtobi

cgtobi approved these changes Jul 18, 2019

Copy link
Collaborator

left a comment

LGTM

@olbjan

This comment has been minimized.

Copy link

commented Jul 18, 2019

I think I found one more mode: "Energy Heat" or "Heat Econ" from my Heatit Z-Therm2
2DD9E232-DD62-49FC-8E83-2BD7F7768121

@balloob

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

@olbjan I am not sure how to translate your info to the mappings, so will merge this now and get it in 96.1.

@stboch could you convert the info from @olbjan into a new PR ? Tag me when you do.

Cheers!

@balloob balloob added this to the 0.96.1 milestone Jul 18, 2019

@balloob balloob merged commit 217da36 into home-assistant:dev Jul 18, 2019

9 checks passed

CI Build #20190718.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python35) Tests PyTest Python35 succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA

balloob added a commit that referenced this pull request Jul 18, 2019

Added states and modes for zwave climate (#25274)
* Update climate.py

Added support for Fan Only State
Added additional missing modes and states this should correct issue #25216

* Correct line lint error

* Corrected mode spelling

* Lint
@balloob balloob referenced this pull request Jul 18, 2019

KJonline added a commit to Rendili/home-assistant that referenced this pull request Jul 19, 2019

Merge branch 'master' of https://github.com/home-assistant/home-assis…
…tant

* 'master' of https://github.com/home-assistant/home-assistant: (888 commits)
  Turn on device before setting mode (home-assistant#25314)
  Bumped version to 0.96.2
  Fix plant error when adding new value (home-assistant#25302)
  Fix HM with use wrong datapoint for off (home-assistant#25298)
  [climate] Correct honeywell supported_features (home-assistant#25292)
  Fixed python-wink method names (home-assistant#25285)
  Fix fritzbox climate HVAC mode / temperature (home-assistant#25275)
  Updated frontend to 20190719.0
  Update azure-pipelines-ci.yml for Azure Pipelines
  Bumped version to 0.96.1
  Added states and modes for zwave climate (home-assistant#25274)
  Add hvac modes back to opentherm (home-assistant#25268)
  Restore SmartThings A/C on/off services (home-assistant#25259)
  Update CT80 Humidity call (home-assistant#25258)
  ecobee Preset Fix (home-assistant#25256)
  Fix the unit of measurement for ecobee climate (home-assistant#25246)
  Make presets prettier (home-assistant#25245)
  Fix eq3btsmart (home-assistant#25238)
  Show off value (home-assistant#25236)
  Updated frontend to 20190718.0
  ...

@lock lock bot locked and limited conversation to collaborators Jul 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.