Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecobee Preset Fix #25256

Merged
merged 5 commits into from
Jul 18, 2019
Merged

ecobee Preset Fix #25256

merged 5 commits into from
Jul 18, 2019

Conversation

geekofweek
Copy link
Contributor

@geekofweek geekofweek commented Jul 18, 2019

Description:

This is to resolve not being able to set presets with the Ecobee Integration. Currently using or setting presets does not work, fix restores basic functionality.

Related issue (if applicable): fixes #25222

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cgtobi
Copy link
Contributor

cgtobi commented Jul 18, 2019

The Celsius fix has already been merged.

@geekofweek
Copy link
Contributor Author

The Celsius fix has already been merged.

I was working off a copy late last night that didn't have it already, so I just made sure they matched up.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob added this to the 0.96.1 milestone Jul 18, 2019
@balloob balloob merged commit 5c53257 into home-assistant:dev Jul 18, 2019
@geekofweek geekofweek deleted the ecobee-fix branch July 18, 2019 17:43
balloob pushed a commit that referenced this pull request Jul 18, 2019
* ecobee Preset Fix

* Celsius Fix

* Checks Fix

* Check Fix #2

* Check Fix #3
@balloob balloob mentioned this pull request Jul 18, 2019
@lock lock bot locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ecobee Integration Borked with Updated Climate
4 participants